This repository was archived by the owner on Feb 12, 2024. It is now read-only.
fix: await pubsub unsubscribe to fix flaky test#3755
Closed
achingbrain wants to merge 1 commit intomasterfrom
Closed
fix: await pubsub unsubscribe to fix flaky test#3755achingbrain wants to merge 1 commit intomasterfrom
achingbrain wants to merge 1 commit intomasterfrom
Conversation
We manage pubsub subscriptions locally in the http client, when we unsubscribe from a given topic, we abort the long-lived connection we're holding open but do not wait for it to actually close. In our tests we unsubscribe then check the subscription list - if we do this before the subscription is torn down it can report that we are still subscribed to the topic we just unsubscribed from. The fix here is to wait for the connection to be torn down before returning from the unsubscribe call, by which point we should no longer have the topic in our subs list.
Member
Author
|
Fixes this sort of error: |
Member
Author
|
Bleugh, didn't fix it, needs more investigation. |
Member
Author
|
Superseded by #3761 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We manage pubsub subscriptions locally in the http client, when we unsubscribe from a given topic, we abort the long-lived connection we're holding open but do not wait for it to actually close.
In our tests we unsubscribe then check the subscription list - if we do this before the subscription is torn down it can report that we are still subscribed to the topic we just unsubscribed from.
The fix here is to wait for the connection to be torn down before returning from the unsubscribe call, by which point we should no longer have the topic in our subs list.